fengling/fengling-risk-control
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(risk-control): fix null safety and magic numbers in aggregates

Browse Source
This commit is contained in:
Sam 2026-02-05 14:49:19 +08:00
parent 0721965af4
commit 22d0427df9
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Fengling.RiskControl.Domain/Aggregates/RiskRules/RiskRule.cs
View File

@ -53,8 +53,8 @@ public class RiskRule : Entity<long>, IAggregateRoot
UpdatedAt = DateTime.UtcNow; UpdatedAt = DateTime.UtcNow;
} }
public T GetConfig<T>() where T : class public T? GetConfig<T>() where T : class
{ {
return System.Text.Json.JsonSerializer.Deserialize<T>(ConfigJson)!; return System.Text.Json.JsonSerializer.Deserialize<T>(ConfigJson);
} }
} }

7
Fengling.RiskControl.Domain/Aggregates/RiskScores/RiskScore.cs
View File

@ -43,11 +43,14 @@ public class RiskScore : Entity<long>, IAggregateRoot
RiskLevel = RiskLevel.Low; RiskLevel = RiskLevel.Low;
} }
private static readonly int HIGH_THRESHOLD = 70;
private static readonly int MEDIUM_THRESHOLD = 30;
private void RecalculateScore() private void RecalculateScore()
{ {
TotalScore = _factors.Sum(f => f.Points); TotalScore = _factors.Sum(f => f.Points);
RiskLevel = TotalScore >= 70 ? RiskLevel.High : RiskLevel = TotalScore >= HIGH_THRESHOLD ? RiskLevel.High :
TotalScore >= 30 ? RiskLevel.Medium : TotalScore >= MEDIUM_THRESHOLD ? RiskLevel.Medium :
RiskLevel.Low; RiskLevel.Low;
} }